Re: [PATCH v5 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
From: Geert Uytterhoeven
Date: Tue Aug 20 2019 - 05:08:15 EST
On Mon, Aug 19, 2019 at 2:17 PM Max Staudt <max@xxxxxxxxx> wrote:
> This is the i2c-icy driver for the ICY board for Amiga computers.
> It connects a PCF8584 I2C controller to the Zorro bus, providing I2C
> connectivity. The original documentation can be found on Aminet:
> IRQ support is currently not implemented, as i2c-algo-pcf is built for
> the ISA bus and a straight implementation of the same stack locks up a
> Zorro machine.
> v5: usleep_range() instead of udelay()
> v3: Fixed %pa format string
> Dropped adapter class.
> Clarified licence.
> Removed clock parameter.
> v2: Matched function names to callbacks from i2c-algo-pcf
> Used z_readb()/z_writeb()
> Removed BROKEN_ON_SMP in Kconfig
> Moved LTC2990 to a separate commit
> Signed-off-by: Max Staudt <max@xxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> --- /dev/null
> +++ b/drivers/i2c/busses/i2c-icy.c
> +static int icy_pcf_getpcf(void *data, int ctl)
> + struct icy_i2c *i2c = (struct icy_i2c *)data;
> + u8 __iomem *address = ctl ? i2c->reg_s1 : i2c->reg_s0;
> + int val = z_readb(address);
> + return val;
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds