Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY
From: Andy Shevchenko
Date: Tue Aug 20 2019 - 09:59:28 EST
On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK)
> For consistency it should be
> #define DR_TY_SHIFT(x) (((x) << 28) & DR_TY_MASK)
> with explanation about 50 Ohm in the code below.
> > + /* Drive impedance: 50 Ohm */
> Nice, you have already a comment here. Just use DR_TY_SHIFT(1)
It should be DR_TY_SHIFT(6) now since I dropped the negation.
With Best Regards,