Re: [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode

From: Dan Murphy
Date: Tue Aug 20 2019 - 11:52:39 EST


On 8/19/19 5:48 AM, Pavel Machek wrote:
On Tue 2019-08-13 13:11:51, Dan Murphy wrote:
Fix the brightness control for I2C mode. Instead of
changing the full scale current register update the ALS target
register for the appropriate banks.

In addition clean up some code errors and random misspellings found
during coding.

Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack

Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver")
Reported-by: Pavel Machek <pavel@xxxxxx>
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
I may prefer register renames to come separately, but ...

I can separate them into a different patch


Acked-by: Pavel Machek <pavel@xxxxxx>