Re: [PATCH 2/6] dt-bindings: net: sun8i-a83t-emac: Add phy-io-supply property
From: OndÅej Jirman
Date: Tue Aug 20 2019 - 12:34:37 EST
On Tue, Aug 20, 2019 at 11:20:22AM -0500, Rob Herring wrote:
> On Tue, Aug 20, 2019 at 9:53 AM <megous@xxxxxxxxxx> wrote:
> > From: Ondrej Jirman <megous@xxxxxxxxxx>
> > Some PHYs require separate power supply for I/O pins in some modes
> > of operation. Add phy-io-supply property, to allow enabling this
> > power supply.
> Perhaps since this is new, such phys should have *-supply in their nodes.
Yes, I just don't understand, since external ethernet phys are so common,
and they require power, how there's no fairly generic mechanism for this
already in the PHY subsystem, or somewhere?
It looks like other ethernet mac drivers also implement supplies on phys
on the EMAC nodes. Just grep phy-supply through dt-bindings/net.
Historical reasons, or am I missing something? It almost seems like I must
be missing something, since putting these properties to phy nodes
seems so obvious.
thank you and regards,
> > Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)