Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

From: Dan Murphy
Date: Tue Aug 20 2019 - 13:48:34 EST


On 8/20/19 11:29 AM, Pavel Machek wrote:

No need to move ctrl_brt_pointer... to keep order consistent with docs.
OK I will reset the patches and get rid of that change.  I think this got
moved when I applied the v1 patch.

+ fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
The computation is wrong ... needs () AFAICT.
Hmm. Doesn't order of operations take precedence?

I will add the () unless checkpatch cribs about them
I may be misunderstanding. What do you expect the computation to be? /
has higher priority than -, right? Can you test it provides expected

Fixed.  I think this is what you expected.

fs_current_val = (led->full_scale_current - LM3532_FS_CURR_MIN) /