Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables
From: Saravana Kannan
Date: Tue Aug 20 2019 - 18:37:16 EST
On Tue, Aug 20, 2019 at 3:27 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > On 07-08-19, 15:31, Saravana Kannan wrote:
> > > + ret = of_property_read_u32(np, "opp-peak-kBps", &bw);
> > > + if (ret)
> > > + return ret;
> > > + new_opp->rate = (unsigned long) bw;
> > > +
> > > + ret = of_property_read_u32(np, "opp-avg-kBps", &bw);
> > > + if (!ret)
> > > + new_opp->avg_bw = (unsigned long) bw;
> > If none of opp-hz/level/peak-kBps are available, print error message here
> > itself..
> But you don't print any error for opp-level today. Seems like it's optional?
> > > +
> > > + return 0;
> > You are returning 0 on failure as well here.
Wait, no. This is not actually a failure. opp-avg-kBps is optional. So
returning 0 is the right thing to do. If the mandatory properties
aren't present an error is returned before you get to th end.