Re: [PATCH v12 6/9] ARM: dts: exynos: add chipid label and syscon compatible

From: Lukasz Luba
Date: Wed Aug 21 2019 - 05:29:16 EST




On 7/24/19 7:10 PM, Krzysztof Kozlowski wrote:
> On Mon, Jul 22, 2019 at 11:46:43AM +0200, Lukasz Luba wrote:
>> Add the chipid label which allows to use it in phandle from other device.
>> Use syscon in compatible to get the regmap of the device register set.
>> The chipid is used in DMC during initialization to compare compatibility.
>>
>
> I cannot find its usage in DMC driver.
You are right, it was used in the old versions. I will skip this patch.

Regards,
Lukasz
>
> Best regards,
> Krzysztof
>
>
>> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
>> index 67f9b4504a42..4801ca759feb 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -35,8 +35,8 @@
>> #size-cells = <1>;
>> ranges;
>>
>> - chipid@10000000 {
>> - compatible = "samsung,exynos4210-chipid";
>> + chipid: chipid@10000000 {
>> + compatible = "samsung,exynos4210-chipid", "syscon";
>> reg = <0x10000000 0x100>;
>> };
>>
>> --
>> 2.17.1
>>
>
>