Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

From: Mike Rapoport
Date: Wed Aug 21 2019 - 11:29:38 EST


On Wed, Aug 21, 2019 at 08:15:44AM -0700, Matthew Wilcox wrote:
> On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote:
> > +++ b/arch/alpha/include/asm/pgtable.h
> > @@ -362,7 +362,6 @@ extern void paging_init(void);
> > /*
> > * No page table caches to initialise
> > */
> > -#define pgtable_cache_init() do { } while (0)
>
> Delete the comment too?
>
> > +++ b/arch/arc/include/asm/pgtable.h
> > @@ -398,7 +398,6 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long address,
> > /*
> > * No page table caches to initialise
> > */
> > -#define pgtable_cache_init() do { } while (0)
>
> ditto
>
> > +++ b/arch/arm/include/asm/pgtable.h
> > @@ -368,7 +368,6 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
> > #define HAVE_ARCH_UNMAPPED_AREA
> > #define HAVE_ARCH_UNMAPPED_AREA_TOPDOWN
> >
> > -#define pgtable_cache_init() do { } while (0)
> >
> > #endif /* !__ASSEMBLY__ */
>
> delete one of the two blank lines?
>
> > +++ b/arch/c6x/include/asm/pgtable.h
> > @@ -62,7 +62,6 @@ extern unsigned long empty_zero_page;
> > /*
> > * No page table caches to initialise
> > */
> > -#define pgtable_cache_init() do { } while (0)
>
> delete comment ... more of these.

Actually, most of them :)
Thanks for spotting this.


--
Sincerely yours,
Mike.