Re: [PATCH v2 2/3] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

From: Ricardo Ribalda Delgado
Date: Wed Aug 21 2019 - 12:40:34 EST


Hi Philipp

On Tue, Aug 20, 2019 at 5:42 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>
> On Tue, 2019-08-20 at 11:40 +0200, Ricardo Ribalda Delgado wrote:
> > New control to pass to userspace the width/height of a pixel. Which is
> > needed for calibration and lens selection.
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@xxxxxxxxxx>
> > ---
> > Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > index 51c1d5c9eb00..b43047d4e7a1 100644
> > --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > @@ -510,6 +510,14 @@ enum v4l2_scene_mode -
> > value down. A value of zero stops the motion if one is in progress
> > and has no effect otherwise.
> >
> > +``V4L2_CID_UNIT_CELL_SIZE (struct)``
> > + This control returns the unit cell size in nanometres. The struct provides
> > + the width and the height in separated fields to take into consideration
> > + asymmetric pixels and/or hardware binning.
> > + The unit cell consist on the whole area of the pixel, sensitive and
> > + non-sensitive.
>
> "consists of", otherwise this looks unambiguous to me.
>
Thanks, fixing on v3. Will send after I get more feedback



> I'm not sure if it is required to add a table for struct v4l2_area,
> similarly to the other compound controls.
>
> > + This control is required for automatic calibration sensors/cameras.
> > +
> > .. [#f1]
> > This control may be changed to a menu control in the future, if more
> > options are required.
>
> regards
> Philipp