Re: [PATCH v4 2/4] nvme-pci: Add support for variable IO SQ element size

From: Christoph Hellwig
Date: Wed Aug 21 2019 - 20:28:27 EST


On Wed, Aug 07, 2019 at 05:51:20PM +1000, Benjamin Herrenschmidt wrote:
> +#define NVME_NVM_ADMSQES 6
> #define NVME_NVM_IOSQES 6
> #define NVME_NVM_IOCQES 4

The NVM in the two defines here stands for the NVM command set,
so this should just be named NVME_ADM_SQES or so. But except for this
the patch looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

So maybe Sagi can just fix this up in the tree.