Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

From: Eric Biggers
Date: Thu Aug 22 2019 - 09:44:17 EST


On Thu, Aug 22, 2019 at 03:55:31PM +0900, Tetsuo Handa wrote:
> Eric Biggers wrote:
> > What happened to this patch?
>
> I have to learn how to manage a git tree for sending
> pull requests, but I can't find time to try.
>
> >
> > Also, isn't the same bug in other places too?:
> >
> > - tomoyo_path_chmod()
> > - tomoyo_path_chown()
> > - smack_inode_getsecurity()
> > - smack_inode_setsecurity()
>
> What's the bug? The file descriptor returned by open(O_PATH) cannot be
> passed to read(2), write(2), fchmod(2), fchown(2), fgetxattr(2), mmap(2) etc.
>

chmod(2), chown(2), getxattr(2), and setxattr(2) take a path, not a fd.

- Eric