Re: [PATCH v1 1/2] x86/rtc: Add option to skip using RTC

[Tanwar, Rahul]

Hi Andy,

On 22/8/2019 5:02 PM, Andy Shevchenko wrote:
> On Thu, Aug 22, 2019 at 03:44:03PM +0800, Rahul Tanwar wrote:
> > Use a newly introduced optional "status" property of "motorola,mc146818"
> > compatible DT node to determine if RTC is supported. Skip read/write from
> > RTC device only when this node is present and status is "disabled". In all
> > other cases, proceed as before.
> Can't we rather update ->get_wallclock() and ->set_wallclock() based on this?


get_wallclock() and set_wallclock() are function pointers of platform_ops

which are initialized to mach_get_cmos_time() and mach_set_rtc_mmss()

at init time. Since adding a new platform to override these functions is

discouraged, so the only way is to modify RTC get/set functions.


Regards,

Rahul