Re: [PATCH V1 1/1] serial: 8250_pci: Add F81504A series Support

From: Greg KH
Date: Thu Aug 22 2019 - 17:15:14 EST


On Mon, Aug 19, 2019 at 08:49:50AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi,
>
> Andy Shevchenko æ 2019/8/16 äå 07:26 åé:
> > On Fri, Aug 16, 2019 at 01:27:29PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> > > Fintek F81504A/508A/512A is PCIE to 4/8/12 UARTs device. It's support
> > > IO/MMIO/PCIE conf to access all functions. The old F81504/508/512 is
> > > only support IO.
> >
> > We have 8250_fintek.
> > Isn't it a right place to add these?
> >
>
> The 8250_fintek implements PNP device with id PNP0501.
> Should I also implements PCIe device in this file?

Does it use the same logic? If so, that makes sense, but if you can not
share anything, then no, it does not make sense.

thanks,

greg k-h