Re: [PATCH] mtd: hyperbus: fix dependency and build error

From: Miquel Raynal
Date: Sat Aug 24 2019 - 06:48:21 EST

Hi Vignesh,

Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote on Tue, 13 Aug 2019 16:03:13

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> lib/devres.c, which implements devm_ioremap_resource(), is only built
> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
> UML builds):
> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
> Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
> Selected by [m]:
> - MTD_HYPERBUS [=m] && MTD [=m]
> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> ---

This patch looks like a good candidate for fixes, shall I send a fixes
PR next week with it? (Acked-by wished)