Re: [GIT pull] x86/urgent for 5.3-rc5
From: Linus Torvalds
Date: Sun Aug 25 2019 - 13:38:27 EST
On Sun, Aug 25, 2019 at 10:30 AM Borislav Petkov <bp@xxxxxxx> wrote:
> Should we do that somewhere in the early boot code by adding a WARN_ON()
> or so and see who screams?
It might be a good idea, just to see if it ever happens (again).
It doesn't even have to be early boot. It's probably more important to
let the user _know_, than it is to then disable the rdrand
Particularly since we might as well just do it in general, and in the
general case we don't even know how to hide it in cpuid. So maybe just
something like "read the rdrand value a few times, make sure it
actually changes" at CPU bring-up (both boot and resume)
It sounds like a stupid test, but considering that AMD has had this
particular bug now several times over at least three different
generations, maybe it's not a stupid test after all.
Who knows what the Chinese CPU's that use the AMD core do? Hygon?
Whatever. Did they get the firmware fixes?