Re: [PATCH 2/3] amlogic: arm: add Amlogic SM1 based Khadas VIM3 variant bindings
From: Neil Armstrong
Date: Mon Aug 26 2019 - 03:42:06 EST
On 25/08/2019 21:51, Martin Blumenstingl wrote:
> Hi Neil,
> the subject should be: dt-bindings: arm: amlogic: ...
> On Fri, Aug 23, 2019 at 10:15 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>> The Khadas VIM3 is also available with the Pin-to-pin compatible
>> Amlogic SM1 SoC in the S905D3 variant package.
>> Change the description to match the S905X3/D3/Y3 variants like the G12A
>> description, and add the vim3 compatible.
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>> Documentation/devicetree/bindings/arm/amlogic.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index b48ea1e4913a..2751dd778ce0 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -150,9 +150,10 @@ properties:
>> - const: amlogic,s922x
>> - const: amlogic,g12b
>> - - description: Boards with the Amlogic Meson SM1 S905X3 SoC
>> + - description: Boards with the Amlogic Meson SM1 S905X3/D3/Y3 SoC
>> - enum:
>> - seirobotics,sei610
>> + - khadas,vim3
Khadas asked me to rename the board to "vim3l", which is the commercial name,
should I only change the DT name or also the compatible "khadas,vim3l" ?
>> - const: amlogic,sm1
> on the GXL we differentiate between S905X and S905D
> do we need to differentiate S905X3 from S905D3 (for example)?
>From a pure SoC die perspective they are the same, exactly like
the S905X and S905D, only the package changes.
So only the board DT will determine which eth PHY is used,
if a DSI panel is connected, a demodulator is connected.. even
if the underlying package is S905Y3 without any of these pins
I'll need kevin's feedback anyway.