Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

From: Guenter Roeck
Date: Mon Aug 26 2019 - 09:21:00 EST

On 8/26/19 1:12 AM, Yuehaibing wrote:

On 2019/8/23 22:05, Alexandre Belloni wrote:
On 23/08/2019 20:45:53+0800, YueHaibing wrote:
If WATCHDOG_CORE is not set, build fails:

drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6':
drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device'

Add WATCHDOG_CORE Kconfig dependency to fix this.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
drivers/rtc/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 25af63d..9dce7dc 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -886,6 +886,8 @@ config RTC_DRV_DS3232_HWMON
config RTC_DRV_PCF2127
tristate "NXP PCF2127"
depends on RTC_I2C_AND_SPI
+ depends on WATCHDOG

Definitively not, I fixed it that way:

No, this still fails while WATCHDOG is not set

Correct, there are no dummy functions for watchdog device registration.
There would have to be conditional code in the driver if the watchdog
is supposed to be optional.