Re: [PATCH RESEND] erofs: fix compile warnings when moving out include/trace/events/erofs.h
From: Gao Xiang
Date: Mon Aug 26 2019 - 10:26:42 EST
On Mon, Aug 26, 2019 at 09:51:35PM +0800, Chao Yu wrote:
> On 2019-8-26 21:26, Gao Xiang wrote:
> > TRACE_EVENT(erofs_lookup,
> > ^~~~~~~~~~~
> > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> > TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > ^~~~~~~~
> > That makes me very confused since most original EROFS tracepoint code
> > was taken from f2fs, and finally I found
> > commit 43c78d88036e ("kbuild: compile-test kernel headers to ensure they are self-contained")
> > It seems these warnings are generated from KERNEL_HEADER_TEST feature and
> > ext4/f2fs tracepoint files were in blacklist.
> For f2fs.h, it will be only used by f2fs module, I guess it's okay to let it
> stay in blacklist...
Yes, it depends on you f2fs folks selection...
Anyway, this file is a new file, therefore it should be better not to add to
> > Anyway, let's fix these issues for KERNEL_HEADER_TEST feature instead
> > of adding to blacklist...
> >  https://lore.kernel.org/lkml/20190826162432.11100665@xxxxxxxxxxxxxxxx/
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
Thanks for reviewing :)