Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations
From: Leonard Crestez
Date: Mon Aug 26 2019 - 10:45:48 EST
On 7/30/2019 5:31 AM, Anson.Huang@xxxxxxx wrote:
> From: Anson Huang <Anson.Huang@xxxxxxx>
> Some platforms like i.MX8MQ has clock control for this module,
> need to add clock operations to make sure the driver is working
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
This series looks good, do you think it can be merged in time for v5.4?
Today was v5.3-rc6.
In an earlier series the CLK_IS_CRITICAL flags was removed from the TMU
clock so if the thermal driver doesn't explicitly enable it the system
will hang on probe. This is what happens in linux-next right now!
Unless this patches is merged soon we'll end up with a 5.4-rc1 that
doesn't boot on imx8mq. An easy fix would be to drop/revert commit
951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for
IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.
Merging patches out-of-order when they have hard (boot-breaking)
dependencies also breaks bisect.