Re: [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC

From: Hawa, Hanna
Date: Mon Aug 26 2019 - 10:49:36 EST

On 8/21/2019 10:17 PM, Rob Herring wrote:
Why is this even in DT? AFAICT, this is all just CortexA57 core features
(i.e. nothing Amazon specific). The core type and the ECC capabilities
are discoverable.

Added to the DT in order to easily enable/disable the driver. You are correct that they are CortexA57 core features and nothing Amazon specific, but it's IMPLEMENTATION DEFINED, meaning that in different cortex revisions (e.g. A57) the register bitmap may change. Because of that we added an Amazon compatible which corresponds to the specific core we are using.