Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs

From: Nayna
Date: Mon Aug 26 2019 - 11:46:45 EST

On 08/26/2019 10:56 AM, Greg Kroah-Hartman wrote:
On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote:
+static struct kobj_attribute size_attr = __ATTR_RO(size);
Wait, why not just normal ATTR_RO()?

Oh!! Sorry. I am not seeing this macro in sysfs.h. am I missing something ?

+static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE);
And BIN_ATTR_RO() here?

This would have worked. I think I just thought to use the same way as __ATTR_RO().
I will change this to __BIN_ATTR_RO and use __BIN_ATTR_WO from your patch.

Thanks for the patch.

Thanks & Regards,
ÂÂÂ - Nayna