Re: [patch V2 31/38] rlimit: Rewrite non-sensical RLIMIT_CPU comment
From: Frederic Weisbecker
Date: Mon Aug 26 2019 - 17:41:56 EST
On Wed, Aug 21, 2019 at 09:09:18PM +0200, Thomas Gleixner wrote:
> The comment above the function which arms RLIMIT_CPU in the posix CPU timer
> code makes no sense at all. It claims that the kernel does not return an
> error code when it rejected the attempt to set RLIMIT_CPU. That's clearly
> bogus as the code does an error check and the rlimit is only set and
> activated when the permission checks are ok. In case of a rejection an
> appropriate error code is returned.
> This is a historical and outdated comment which got dragged along even when
> the rlimit handling code was rewritten.
> Replace it with an explanation why the setup function is not called when
> the rlimit value is RLIM_INFINITY and how the 'disarming' is handled.
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxxx>
Reviewed-by: Frederic Weisbecker <frederic@xxxxxxxxxx>