Re: Linux-next-20190823: x86_64/i386: prot_hsymlinks.c:325: Failed to run cmd: useradd hsym
From: Naresh Kamboju
Date: Tue Aug 27 2019 - 02:34:34 EST
On Tue, 27 Aug 2019 at 04:42, Jan Stancek <jstancek@xxxxxxxxxx> wrote:
> ----- Original Message -----
> > On Mon, 2019-08-26 at 10:38 -0400, Jan Stancek wrote:
> No change with that patch,
Same for me.
> but following one fixes it for me:
Works for me.
Thanks for the fix patch.
> diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
> index 20b3717cd7ca..56cefa0ab804 100644
> --- a/fs/nfs/pagelist.c
> +++ b/fs/nfs/pagelist.c
> @@ -590,7 +590,7 @@ static void nfs_pgio_rpcsetup(struct nfs_pgio_header *hdr,
> hdr->res.fattr = &hdr->fattr;
> - hdr->res.count = 0;
> + hdr->res.count = count;
> hdr->res.eof = 0;
> hdr->res.verf = &hdr->verf;
> which is functionally revert of "NFS: Fix initialisation of I/O result struct in nfs_pgio_rpcsetup".
> This hunk caught my eye, could res.eof == 0 explain those I/O errors?
> /* Emulate the eof flag, which isn't normally needed in NFSv2
> * as it is guaranteed to always return the file attributes
> if (hdr->args.offset + hdr->res.count >= hdr->res.fattr->size)
> hdr->res.eof = 1;