Re: [PATCH v2 2/3] fbdev: fbmem: allow overriding the number of bootup logos

[Peter Rosin]

On 2019-08-27 10:36, Geert Uytterhoeven wrote:
> Hi Peter,
> 
> On Mon, Aug 26, 2019 at 10:46 PM Peter Rosin <peda@xxxxxxxxxx> wrote:
>> Probably most useful if you only want one logo regardless of how many
>> CPU cores you have.
>>
>> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
> 
> Thanks for your patch!
> 
>> --- a/Documentation/fb/fbcon.rst
>> +++ b/Documentation/fb/fbcon.rst
>> @@ -174,6 +174,11 @@ C. Boot options
>>         displayed due to multiple CPUs, the collected line of logos is moved
>>         as a whole.
>>
>> +9. fbcon=logo-count:<n>
>> +
>> +       The value 'n' overrides the number of bootup logos. Zero gives the
>> +       default, which is the number of online cpus.
> 
> Isn't that a bit unexpected for the user?
> What about making -1 the default (auto), and zero meaning no logos?

I just naively assumed there was some other mechanism to disable it.

Sigh, I'll take a look. v3 coming up...

Cheers,
Peter