Re: [PATCH v3 2/4] backlight: Expose brightness curve type through sysfs

From: Lee Jones
Date: Tue Aug 27 2019 - 05:45:05 EST


[...]

> > IIUC the conclusion is that there is no need for a string attribute
> > because we only need to distinguish between 'perceptual' and
> > 'non-perceptual'. If that is correct, do you have any preference for
> > the attribute name ('perceptual_scale', 'perceptual', ...)?
>
> More a summary than a conclusion! There is a reason I have left a bit or
> space for others to comment on this over the last month (and a bit).
>
> To be clear my Reviewed-by: means that I believe that the kernel is better
> with "non-linear/linear/unknown" than without it and that I am comfortable
> the API isn't likely to be a millstone for us.
>
> Lee, Jingoo: Either of you care to offer $0.02

No, not really. Happy to leave it to your good judgement.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog