Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct
From: Matthias Brugger
Date: Tue Aug 27 2019 - 06:04:11 EST
On 27/08/2019 06:12, Bibby Hsieh wrote:
>>> int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event)
>>> - u32 arg_b;
>>> + struct cmdq_instruction *inst;
>>> if (event >= CMDQ_MAX_EVENT)
>>> return -EINVAL;
>>> - /*
>>> - * WFE arg_b
>>> - * bit 0-11: wait value
>>> - * bit 15: 1 - wait, 0 - no wait
>>> - * bit 16-27: update value
>>> - * bit 31: 1 - update, 0 - no update
>>> - */
>> I have no strong opinion of CMDQ_WFE_OPTION but if you want to introduce it,
>> then please copy the comment over to include/linux/mailbox/mtk-cmdq-mailbox.h
> Ok. let's move the descriptions to header.
>> Just one question, why did you call it _OPTION? It's not really expressive for me.
> Actually, _OPTION is come from our hardware design name...
Ok, then I'll stop bike-shedding. I leave it up to you to rename it or not.