Re: [PATCH v6 2/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample
From: Code Kipper
Date: Tue Aug 27 2019 - 06:56:01 EST
On Tue, 27 Aug 2019 at 11:34, Maxime Ripard <mripard@xxxxxxxxxx> wrote:
> On Mon, Aug 26, 2019 at 08:07:33PM +0200, codekipper@xxxxxxxxx wrote:
> > From: Marcus Cooper <codekipper@xxxxxxxxx>
> > On the newer SoCs such as the H3 and A64 this is set by default
> > to transfer a 0 after each sample in each slot. However the A10
> > and A20 SoCs that this driver was developed on had a default
> > setting where it padded the audio gain with zeros.
> > This isn't a problem whilst we have only support for 16bit audio
> > but with larger sample resolution rates in the pipeline then SEXT
> > bits should be cleared so that they also pad at the LSB. Without
> > this the audio gets distorted.
> > Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx>
> If anything, I'd like to have less regmap_fields rather than more of
> them. This is pretty easy to add to one of the callbacks, especially
> since the field itself has been completely reworked from one
> generation to the other.
That's fine....I've been doing that with the patches which follow this.
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering