Re: [PATCH] uuid: Add helpers for finding UUID from an array
From: Heikki Krogerus
Date: Tue Aug 27 2019 - 08:26:23 EST
On Tue, Aug 27, 2019 at 01:54:18PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 02:49:18PM +0300, Heikki Krogerus wrote:
> > Matching function that compares every UUID in an array to a
> > given UUID with guid_equal().
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > ---
> > Hi,
> > I don't have a user for these helpers, but since they are pretty
> > trivial, I figured that might as well propose them in any case.
> > Though, I think there was somebody proposing of doing the same thing
> > that these helpers do at one point, but just the hard way in the
> > drivers, right Andy?
> XFS has something similar in xfs_uuid_mount, except that it also
> tracks empty slots. That beeing said I'm pretty sure if you ask willy
> he's suggest to just convert the table to an xarray instead :)
> So I'm defintively curious what the users would be where we just check
> a table, but don't also add something to the table.
I prepared this patch (already some time ago) as part of a series that
was meant to move the ACPI _DSD uuids "prp_guids" in
drivers/acpi/property.c to the drivers instead (so in practice, get
rid of prp_guids). I never send that series out because it would have
only worked with ACPI enumerated devices, so not with for example PCI
enumerated devices which also may have _DSD device properties.
I'm sending this patch out just because after this I'm dropping it
from my development branch. If somebody else finds it useful, great,
let's push it forward, but if there is nobody interested, or if there
is possibly even better way of handling arrays like prp_guids (please
note that I'm not going to work on that ;-), then let's just forget
about the it.