Re: [PATCH] mmc: sunxi: fix unusuable eMMC on some H6 boards by disabling DDR
From: Ulf Hansson
Date: Tue Aug 27 2019 - 09:25:05 EST
On Sun, 25 Aug 2019 at 17:06, Alejandro GonzÃlez
> Some Allwinner H6 boards have timing problems when dealing with
> DDR-capable eMMC cards. These boards include the Pine H64 and Tanix TX6.
> These timing problems result in out of sync communication between the
> driver and the eMMC, which renders the memory unsuable for every
> operation but some basic commmands, like reading the status register.
> The cause of these timing problems is not yet well known, but they go
> away by disabling DDR mode operation in the driver. Like on some H5
> boards, it might be that the traces are not precise enough to support
> these speeds. However, Jernej Skrabec compared the BSP driver with this
> driver, and found that the BSP driver configures pinctrl to operate at
> 1.8 V when entering DDR mode (although 3.3 V operation is supported), while
> the mainline kernel lacks any mechanism to switch voltages dynamically.
> Finally, other possible cause might be some timing parameter that is
> different on the H6 with respect to other SoCs.
> Therefore, as this fix works reliably, the kernel lacks the required
> dynamic pinctrl control for now and a slow eMMC is better than a not
> working eMMC, just disable DDR operation for now on H6-compatible
> Signed-off-by: Alejandro GonzÃlez <alejandro.gonzalez.correo@xxxxxxxxx>
Assuming this should go stable as well? Perhaps you can find a
relevant commit that we can put as a fixes tag as well?
> drivers/mmc/host/sunxi-mmc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index d577a6b0ceae..dac57d76d009 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1395,14 +1395,17 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
> * Some H5 devices do not have signal traces precise enough to
> - * use HS DDR mode for their eMMC chips.
> + * use HS DDR mode for their eMMC chips. Other H6 devices operate
> + * unreliably on HS DDR mode, too.
> * We still enable HS DDR modes for all the other controller
> - * variants that support them.
> + * variants that support them properly.
> if ((host->cfg->clk_delays || host->use_new_timings) &&
> - "allwinner,sun50i-h5-emmc"))
> + "allwinner,sun50i-h5-emmc") &&
> + !of_device_is_compatible(pdev->dev.of_node,
> + "allwinner,sun50i-h6-emmc"))
> mmc->caps |= MMC_CAP_1_8V_DDR | MMC_CAP_3_3V_DDR;
> ret = mmc_of_parse(mmc);