Re: WARNINGs in set_task_reclaim_state with memory cgroupandfullmemory usage

From: Michal Hocko
Date: Tue Aug 27 2019 - 09:53:26 EST


On Tue 27-08-19 21:29:24, Hillf Danton wrote:
>
> >> No preference seems in either way except for retaining
> >> nr_to_reclaim == SWAP_CLUSTER_MAX and target_mem_cgroup == memcg.
> >
> > Setting target_mem_cgroup here may be a very subtle change for
> > subsequent processing.
> > Regarding retraining nr_to_reclaim == SWAP_CLUSTER_MAX, it may not
> > proper for direct reclaim, that may cause some stall if we iterate all
> > memcgs here.
>
> Mind posting a RFC to collect thoughts?

I hope I have explained why this is not desirable
http://lkml.kernel.org/r/20190827120335.GA7538@xxxxxxxxxxxxxx
--
Michal Hocko
SUSE Labs