Re: [PATCH v5 4/4] KEYS: trusted: move tpm2 trusted keys code
From: Jarkko Sakkinen
Date: Tue Aug 27 2019 - 10:17:54 EST
On Wed, Aug 21, 2019 at 06:29:05PM +0530, Sumit Garg wrote:
> +// SPDX-License-Identifier: GPL-2.0-only
> + * Copyright (C) 2004 IBM Corporation
> + * Copyright (C) 2014 Intel Corporation
Everything below can be dropped from this new file. Git has the most
accurate authority information.
I'm not sure why I added the authors-list in the first place to the
header when I implemented these functions as none of those folks have
contributed to this particular piece of work.
> + * Authors:
> + * Leendert van Doorn <leendert@xxxxxxxxxxxxxx>
> + * Dave Safford <safford@xxxxxxxxxxxxxx>
> + * Reiner Sailer <sailer@xxxxxxxxxxxxxx>
> + * Kylene Hall <kjhall@xxxxxxxxxx>
> + *
> + * Maintained by: <tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx>
> + *
> + * Trusted Keys code for TCG/TCPA TPM2 (trusted platform module).
> + */
To summarize, I think this would be sufficient:
// SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2004 IBM Corporation
* Copyright (C) 2014 Intel Corporation
I think there should never be such a rush that acronym could not be
written with the correct spelling. I'm referring to 'tpm2' in the short
summary. I'm sorry, I had to say it, just can't help myself with those
kind of details :-) I can take care of fixing those once I apply these
You've done an awesome job. Thank you.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Unfortunately I'm not yet sure if I have time to test these before going
to Linux Plumbers but these would be anyway too close to the next merge
window to be added to the v5.4 PR.