Re: [PATCH] tpm_tis: Fix interrupt probing
From: Jarkko Sakkinen
Date: Tue Aug 27 2019 - 11:19:21 EST
On Tue, Aug 27, 2019 at 04:14:00PM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 20, 2019 at 08:25:17AM -0400, Stefan Berger wrote:
> > From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > The interrupt probing of the TPM TIS was broken since we are trying to
> > run it without an active locality and without the TPM_CHIP_FLAG_IRQ set.
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> Need these:
> Cc: linux-stable@xxxxxxxxxxxxxxx
> Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> Thank you. I'll apply this to my tree.
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
The commit went in the following form:
I refined the long description as they should be written in imperative
form. I also changed it to consistently to speak about tpm_tis_core
instead of using two differing spellings (tpm_tis and TPM TIS). tpm_tis
is a different module than tpm_tis_core.
Unfortunately I had to drop the assignment statement because:
1. Generally speaking, two separate bug fixes should never reside in the
same commit. They even need their own fixes tags in this case.
2. The commit message did not reason the assignment statement.