Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
From: Ladislav Michl
Date: Tue Aug 27 2019 - 14:15:04 EST
On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote:
> * Markus Elfring <Markus.Elfring@xxxxxx> [190826 06:31]:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Mon, 26 Aug 2019 15:05:31 +0200
> > A null pointer would be passed to a call of the function "kfree" directly
> > after a call of the function "kzalloc" failed at one place.
> > Remove this superfluous function call.
> > This issue was detected by using the Coccinelle software.
> Applying into omap-for-v5.4/soc thanks.
Is it really wise touching almost dead code? Last user is pandora board, so
+Cc: Nikolaus Schaller <hns@xxxxxxxxxxxxx>