Re: [PATCH 2/2] powerpc: cleanup hw_irq.h

From: Segher Boessenkool
Date: Tue Aug 27 2019 - 15:12:21 EST


On Tue, Aug 27, 2019 at 08:33:45PM +0200, Christophe Leroy wrote:
> >So
> > asm("add%I2 %0,%1,%2" : "=r"(dst) : "r"(src1), "ri"(src1));
>
> "ri", not "n" as for wrtee ?

"n" means a number. "i" means any constant integer. The difference is
mostly that "n" does not allow relocations. This probably does not matter
for this asm, not if you call it with correct values anyway.

(If you want to pass other than small numbers here, you need different
constraints; let's not go there).


Segher