Re: [PATCH 2/8] regulator: add support for SY8824C regulator
From: Mark Brown
Date: Tue Aug 27 2019 - 15:45:05 EST
On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote:
This looks mostly good and I'll apply it, a couple of small
> @@ -0,0 +1,192 @@
> +// SPDX-License-Identifier: GPL-2.0
> + * SY8824C regulator driver
> + *
Please send a patch which updates the entire comment block to be
C++ style so it looks consistent.
> +#define BUCK_EN (1 << 7)
> +#define MODE (1 << 6)
Please also add prefixes to these to namespace them, especially
MODE is likely to collide with something later.
Description: PGP signature