RE: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host
From: Wei Hu
Date: Wed Aug 28 2019 - 04:45:22 EST
> -----Original Message-----
> From: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > Beginning from Windows 10 RS5+, VM screen resolution is obtained from host.
> > The "video=hyperv_fb" boot time option is not needed, but still can be
> > used to overwrite what the host specifies. The VM resolution on the host
> > could be set by executing the powershell "set-vmvideo" command.
> > v2:
> > - Implemented fallback when version negotiation failed.
> > - Defined full size for supported_resolution array.
> > v3:
> > - Corrected the synthvid major and minor version comparison problem.
> The changelog for v2 and v3 should actually go after the "---" below so
> that the changelog does not end up as part of the commit message. Take
> a look at other postings to LKML for an example.
I saw people putting v2 and vN in commit message. The git log of this file also
contains similar lines like v2. But if you prefer I can move it after ---.
> > Signed-off-by: Iouri Tarassov <iourit@xxxxxxxxxxxxx>
> > Signed-off-by: Wei Hu <weh@xxxxxxxxxxxxx>
> > ---
> > drivers/video/fbdev/hyperv_fb.c | 159 +++++++++++++++++++++++++++++---
> > 1 file changed, 147 insertions(+), 12 deletions(-)
> > +/* Check if the ver1 version is equal or greater than ver2 */
> > +static inline bool synthvid_ver_eg(u32 ver1, u32 ver2)
> I'm being picky here, but I would call this synthvid_ver_ge(). In my
> experience "ge" is the shorthand for "greater than or equal", rather
> than the "eg" you have used.