Re: [PATCH v2 1/4] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls

From: Borislav Petkov
Date: Wed Aug 28 2019 - 04:46:03 EST


On Wed, Aug 28, 2019 at 09:45:19AM +0200, Thomas HellstrÃm (VMware) wrote:
> Hmm, we're missing a return 0; here. The number of return points and the
> moved up variable declarations worries me a little. I'll see if I can clean
> this up a bit, but would prefer to make a follow-up patch in that case.

By all means.

It was just a suggestion anyway - see if you prefer this better or would
like to keep the old style.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.