RE: [PATCH V3 1/5] thermal: qoriq: Add clock operations
From: Anson Huang
Date: Wed Aug 28 2019 - 04:49:51 EST
> On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote:
> > On Tue, 2019-08-27 at 12:41 +0000, Leonard Crestez wrote:
> > > On 27.08.2019 04:51, Anson Huang wrote:
> > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from
> > > > > the TMU clock so if the thermal driver doesn't explicitly enable
> > > > > it the system will hang on probe. This is what happens in
> > > > > linux-next right now!
> > > >
> > > > The thermal driver should be built with module, so default kernel
> > > > should can boot up, do you modify the thermal driver as built-in?
> > > >
> > > > > Unless this patches is merged soon we'll end up with a 5.4-rc1
> > > > > that doesn't boot on imx8mq. An easy fix would be to drop/revert
> > > > > commit
> > > > > 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for
> > > > > IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.
> > > >
> > > > If the thermal driver is built as module, I think no need to
> > > > revert the commit, but if by default thermal driver is built-in or
> > > > mod probed, then yes, it should NOT break kernel boot up.
> > >
> > > The qoriq_thermal driver is built as a module in defconfig and when
> > > modules are properly installed in rootfs they will be automatically
> > > be probed on boot and cause a hang.
> > >
> > > I usually run nfsroot with modules:
> > >
> > > make modules_install INSTALL_MOD_PATH=/srv/nfs/imx8-root
> > so we need this patch shipped in the beginning of the merge window,
> > right?
> > if there is hard dependency between patches, it's better to send them
> > in one series, and get shipped via either tree.
> > BTW, who is maintaining qoriq driver from NXP? If Anson is maintaining
> > and developing this driver, it's better to update this in the driver
> > or the MAINTAINER file, I will take the driver specific patches as
> > long as we have ACK/Reviewed-By from the driver maintainer.
I am NOT sure who is the qoriq driver from NXP, some of our i.MX SoCs use
qoriq thermal IP, so I have to add support for them. The first maintainer for
this driver is hongtao.jia@xxxxxxx, but I can NOT find it from NXP's mail system,
NOT sure if he is still in NXP. The MAINTAINER file does NOT have info for this
Driver's maintainer, so how to update it? Just change the name in driver? Or leave
it as what it is?
MODULE_AUTHOR("Jia Hongtao <hongtao.jia@xxxxxxx>");
MODULE_DESCRIPTION("QorIQ Thermal Monitoring Unit driver");
> And also, can you provide your feedback for this one?
I can take a look at it later.