Re: [PATCH] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c

From: Krzysztof Wilczynski
Date: Wed Aug 28 2019 - 06:59:51 EST

Hello Bjorn,

Thank you for the feedback.
Make the log facility used to print warnings to be KERN_WARNING
explicitly, rather than rely on the current (or default) value
of the MESSAGE_LOGLEVEL_DEFAULT set in Kconfig. This will make
all the warnings in the arch/x86/pci/pcbios.c to be printed
consistently at the same log facility.

This is slightly confusing. There are only two messages that didn't
supply a log level, so the avoidance of MESSAGE_LOGLEVEL_DEFAULT
applies to those.

Good point. I will update both the wording and the explanation so that
it would be more accurate and make a whole lot more sense.

Might be worth doing this as well:

#define pr_fmt(fmt) "PCI: " fmt

and removing the "PCI: " prefix from the messages. This would change
the "bios32_service" output slightly, but I think the change would be
a good one.

Will do. The v2 have all the improvements. Thank you!