Re: [PATCHv5] drivers/amba: add reset control to amba bus probe
From: Dinh Nguyen
Date: Wed Aug 28 2019 - 09:34:26 EST
-----BEGIN PGP SIGNED MESSAGE-----
On 8/27/19 2:25 PM, Valdis Kl?tnieks wrote:
> On Mon, 26 Aug 2019 10:42:52 -0500, Dinh Nguyen said:
>> The primecell controller on some SoCs, i.e. SoCFPGA, is held in
>> reset by default. Until recently, the DMA controller was brought
>> out of reset by the bootloader(i.e. U-Boot). But a recent change
>> in U-Boot, the peripherals that are not used are held in reset
>> and are left to Linux to bring them out of reset.
>> Add a mechanism for getting the reset property and de-assert the
>> primecell module from reset if found. This is a not a hard fail
>> if the reset properti is not present in the device tree node, so
>> the driver will continue to probe.
> Does this DTRT for both old and new U-Boots? My naive reading of
> this patch
What is a DTRT?
> says on an old U-Boot, we end up attempting to bring it out of
> reset even though they had already been brought out.
If the peripheral is already out of reset, de-asserting the reset has
-----BEGIN PGP SIGNATURE-----
-----END PGP SIGNATURE-----