Re: [PATCH v2] USB: serial: ftdi_sio: add support for FT232H CBUS gpios
From: Johan Hovold
Date: Wed Aug 28 2019 - 09:39:34 EST
On Thu, Aug 15, 2019 at 05:40:54PM +0000, Matthew Michilot wrote:
> Enable support for cbus gpios on FT232H. The cbus configuration is
> stored in one word in the EEPROM at byte-offset 0x1a with the mux
You forgot to fix the copy-paste error here; it should be "two words" as
I mentioned before.
> config for ACBUS5, ACBUS6, ACBUS8 and ACBUS9 (only pins that can be
> configured as I/O mode).
> Tested using FT232H by configuring one ACBUS pin at a time.
> Signed-off-by: Matthew Michilot <matthew.michilot@xxxxxxxxx>
> Reviewed-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> - made hex notation all lowercase for consistency
> - allocated 4 bytes instead of 2 bytes for buffer
> - improved documentation on FT232H CBUS memory mapping
> - fixed CBUS pins being incorrectly mapped to the wrong gpios
> - sorted case labels alphabetically
Now applied after amending the commit message.