Re: [linux-next][BUG][driver/scsi/lpfc][c00f62e6] Kernel panics when booting next kernel on my Power 9 box

From: Abdul Haleem
Date: Wed Aug 28 2019 - 13:43:18 EST


On Wed, 2019-08-28 at 08:22 -0700, James Smart wrote:
> On 8/27/2019 10:02 PM, Abdul Haleem wrote:
> > Greetings,
> >
> > linux-next kernel 5.3.0-rc1 failed to boot with kernel Oops on Power 9
> > box
> >
> > I see a recent changes to lpfc code was from commit
> > 10541f03 scsi: lpfc: Update lpfc version to 12.4.0.0
> >
> > Recent boot logs:
> >
> > [..snip..]
>
> see https://www.spinics.net/lists/linux-scsi/msg133343.html
>
> It hasn't been tested yet, but appears to be the issue.

Ah, commit c00f62e6 (scsi: lpfc: Merge per-protocol...) is the bad one
and Yes the patch fixes it, System booted fine with below code change

--- a/drivers/scsi/lpfc/lpfc_sli.c 2019-08-23 13:55:18.253546775 -0700
+++ b/drivers/scsi/lpfc_sli.c 2019-08-27 17:04:51.095330056 -0700
@@ -5553,7 +5553,7 @@ lpfc_sli4_arm_cqeq_intr(struct lpfc_hba
for (qidx = 0; qidx < phba->cfg_hdw_queue; qidx++) {
qp = &sli4_hba->hdwq[qidx];
/* ARM the corresponding CQ */
- sli4_hba->sli4_write_cq_db(phba, qp[qidx].io_cq, 0,
+ sli4_hba->sli4_write_cq_db(phba, qp->io_cq, 0,
LPFC_QUEUE_REARM);


Tested-by: Abdul Haleem <abdhalee@xxxxxxxxxxxxxxxxxx>

--
Regard's

Abdul Haleem
IBM Linux Technology Centre