Re: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.

From: Hari Bathini
Date: Thu Aug 29 2019 - 01:21:02 EST

On 28/08/19 10:37 PM, Michal SuchÃnek wrote:
> On Tue, 27 Aug 2019 17:57:31 +0530
> Hari Bathini <hbathini@xxxxxxxxxxxxx> wrote:


>> Also, get rid of the error message when fadump is
>> not supported as it is already taken care of in fadump_reserve_mem() function.
> That should not be called in that case, should it?

fadump_reserve_mem() is called during early boot while this is an initcall that happens
later. Not sure if we can make the initcall conditional on fadump support though..

> Anyway, I find the message right next to the message about reserving
> memory for kdump. So it really looks helpful in the log.

The message you see right after memory reservation for kdump is coming from
fadump_reserve_mem() function. This is the repeat of the same message logged
much later...

- Hari