Re: [PATCH] staging: exfat: add exfat filesystem code to staging
From: Christoph Hellwig
Date: Thu Aug 29 2019 - 05:41:47 EST
On Thu, Aug 29, 2019 at 08:39:55AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote:
> > Can we please just review the damn thing and get it into the proper
> > tree? That whole concept of staging file systems just has been one
> > fricking disaster, including Greg just moving not fully reviewed ones
> > over like erofs just because he feels like it. I'm getting sick and
> > tired of this scheme.
> For this filesystem, it's going to be a _lot_ of work before that can
> happen, and I'd really like to have lots of people help out with it
> instead of it living in random github trees for long periods of time.
Did you actually look at the thing instead of blindly applying some
pile of crap?
It basically is a reimplementation of fs/fat/ not up to kernel standards
with a few indirections thrown in to also support exfat. So no amount
of work on this codebase is really going to bring us forward. Instead
someone how can spend a couple days on this and actually has file
systems to test it just needs to bring the low-level format bits over
to our well tested fs/fat codebase instead of duplicating it.