Re: [PATCH v2 1/2 RESEND] usb: core: phy: add support for PHY calibration
From: Marek Szyprowski
Date: Thu Aug 29 2019 - 06:27:42 EST
On 2019-08-29 12:21, Greg Kroah-Hartman wrote:
> On Thu, Aug 29, 2019 at 07:26:50AM +0200, Marek Szyprowski wrote:
>> Hi Greg,
>> On 2019-08-28 22:41, Greg Kroah-Hartman wrote:
>>> On Mon, Aug 26, 2019 at 10:55:33AM +0200, Marek Szyprowski wrote:
>>>> Hi Greg
>>>> On 2019-08-08 11:41, Marek Szyprowski wrote:
>>>>> Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be
>>>>> done after every USB HCD reset. Generic PHY framework has been already
>>>>> extended with phy_calibrate() function in commit 36914111e682 ("drivers:
>>>>> phy: add calibrate method"). This patch adds support for it to generic
>>>>> PHY handling code in USB HCD core.
>>>>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>>>>> Tested-by: Anand Moon <linux.amoon@xxxxxxxxx>
>>>>> Tested-by: Jochen Sprickerhof <jochen@xxxxxxxxxxxxxx>
>>>> Greg: any chance to give it this a try in -next? If not, maybe You can
>>>> point someone whose review will help?
>>> Ah crap, this is me, not the PHY maintainer :(
>>> Can you resend this and I will be glad to review it. But it would also
>>> be good to get Felipe's review as well.
>> No problem, I will resend it again in a few minutes. Felipe already
>> acked it: https://lkml.org/lkml/2019/8/8/460
> I don't see the resend, did I miss it?
I looks so: https://lkml.org/lkml/2019/8/29/31
> And can you add Felipe's ack to it?
Yes, I've already did that.
Marek Szyprowski, PhD
Samsung R&D Institute Poland