Re: [PATCH v3 1/2] net: core: Notify on changes to dev->promiscuity.

From: Ivan Vecera
Date: Thu Aug 29 2019 - 09:39:34 EST

On Thu, 29 Aug 2019 15:15:43 +0200
Andrew Lunn <andrew@xxxxxxx> wrote:

> The problem with this is, the driver only gets called when promisc
> goes from 0 to !0. So, the port is added to the bridge. Promisc goes
> 0->1, and the driver gets called. We can evaluate as you said above,
> and leave the port filtering frames, not forwarding everything. When
> tcpdump is started, the core does promisc 1->2, but does not call into
> the driver. Also, currently sending a notification is not
> unconditional.

Hi Andrew,

got it. What about to change the existing notify call so NETDEV_CHANGE
notification will be also sent when (old_promiscuity !=