Re: [PATCH] freezer,NFS: add an unsafe schedule_timeout_interruptable freezable helper for NFS

From: Benjamin Coddington
Date: Thu Aug 29 2019 - 11:31:07 EST

Thanks robot!

I'll send a v2 that works with !CONFIG_FREEZER.


On 29 Aug 2019, at 7:02, kbuild test robot wrote:

Hi Benjamin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190828]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

config: x86_64-randconfig-f004-201934 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

fs/nfs/nfs4proc.c: In function 'nfs4_delay_interruptible':
fs/nfs/nfs4proc.c:418:2: error: implicit declaration of function 'freezable_schedule_timeout_interruptible_unsafe'; did you mean 'freezable_schedule_timeout_interruptible'? [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

vim +418 fs/nfs/nfs4proc.c

414 static int nfs4_delay_interruptible(long *timeout)
415 {
416 might_sleep();
418 freezable_schedule_timeout_interruptible_unsafe(nfs4_update_delay(timeout));
419 if (!signal_pending(current))
420 return 0;
421 return __fatal_signal_pending(current) ? -EINTR :-ERESTARTSYS;
422 }

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation