Re: [PATCH v5 3/3] i2c: piix4: Add ACPI support
From: Wolfram Sang
Date: Thu Aug 29 2019 - 16:21:07 EST
On Fri, Aug 02, 2019 at 02:55:26PM +0200, Jean Delvare wrote:
> Enable the i2c-piix4 SMBus controller driver to enumerate I2C slave
> devices using ACPI. It builds on the related I2C mux device work
> in commit 8eb5c87a92c0 ("i2c: add ACPI support for I2C mux ports")
> In the i2c-piix4 driver the adapters are enumerated as:
> Main SMBus adapter Port 0, Port 2, ..., aux port (i.e., ASF adapter)
> However, in the AMD BKDG documentation, the implied order of ports is:
> Main SMBus adapter Port 0, ASF adapter, Port 2, Port 3, ...
> This ordering difference is unfortunate. We assume that ACPI
> developers will use the AMD documentation ordering, so we have to
> pass an extra parameter to piix4_add_adapter().
>  52740 BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h
> Models 30h-3Fh Processors
> Based on earlier work by Andrew Cooks.
> Reported-by: Andrew Cooks <andrew.cooks@xxxxxxxxxxxx>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Applied to for-next, thanks!
Description: PGP signature