Re: [PATCH] tpm_tis: Fix interrupt probing

From: Stefan Berger
Date: Thu Aug 29 2019 - 20:11:37 EST

On 8/29/19 12:10 PM, Jarkko Sakkinen wrote:
On Thu, Aug 29, 2019 at 04:20:21PM +0300, Jarkko Sakkinen wrote:
On Tue, Aug 27, 2019 at 03:34:36PM -0400, Stefan Berger wrote:
On 8/27/19 11:19 AM, Jarkko Sakkinen wrote:
On Tue, Aug 27, 2019 at 04:14:00PM +0300, Jarkko Sakkinen wrote:
On Tue, Aug 20, 2019 at 08:25:17AM -0400, Stefan Berger wrote:
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>

The interrupt probing of the TPM TIS was broken since we are trying to
run it without an active locality and without the TPM_CHIP_FLAG_IRQ set.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
Need these:

Cc: linux-stable@xxxxxxxxxxxxxxx
Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")

Thank you. I'll apply this to my tree.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
The commit went in the following form:
I saw you dropped the stetting of the IRQ flag - I needed it, otherwise it
wouldn't execute certain code paths.
I explained why I removed that part. There was no any reasoning for
it. Also, it cannot be in the same commit if it fixes a diffent
AFAIK they go with different fixes-tags.

I sent a separate patch for this. It looks like this bug goes back to when the TPM_CHIP_FLAG_IRQ was introduced in March 2019?!

ÂÂ Stefan