Re: [PATCH] asm-generic: add unlikely to default BUG_ON(x)
From: Kees Cook
Date: Fri Aug 30 2019 - 16:48:00 EST
On Fri, Aug 30, 2019 at 10:08:49PM +0200, Arnd Bergmann wrote:
> On Wed, Aug 28, 2019 at 11:09 PM Denis Efremov <efremov@xxxxxxxxx> wrote:
> > Add unlikely to default BUG_ON(x) in !CONFIG_BUG. It makes
> > the define consistent with BUG_ON(x) in CONFIG_BUG.
> > Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: <linux-arch@xxxxxxxxxxxxxxx>
> This makes sense, I've applied it to the asm-generic tree for now.
> Two concerns though:
> - adding unlikely() can cause new (usually false-postive) compile time
> warnings to show up in random configurations, so we'll have to see what
> the build bots think
> - Kees Cook has recently sent a series for asm/bug.h that was merged by
> Andrew Morton. If there are is a conflict with your patch, it may be better
> to merge both through the same tree, either linux-mm or asm-generic.
FWIW, this patch looks sensible to me. :)
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>